Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add object tagging - Moodle 404 #653

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

matthewhilton
Copy link
Contributor

@matthewhilton matthewhilton commented Dec 6, 2024

Cherry pick of #619 to MOODLE_404_STABLE branch
This code has already been reviewed & tested, this is purely a forward-port.

Did make some very small php version specific tweaks to fix some deprecations in the newer php version

Testing

  • Tested manually including upgrade from previous version - successfully completes
  • unit tests run with s3 integration client - successfully completes

@matthewhilton matthewhilton marked this pull request as draft December 6, 2024 04:18
* feat: add object tagging

* test: fix unit test count checking

* tagging: don't wait for object lock

* tagging: improve migration controls and progress visibility

* feat: move tagging status reports to check api

* feat: display header with status report

* refactor: integrate tagpushedtime into single update query

* refactor: store tags against object id instead of hash

* chore: organise tagging lang strings

* bugfix: fix mysql query compatibility

* tagging: move mimetype to metadata, add location/orphan tag source

* tagging: check environment config length

* settings: use admin_setting_check if available

* report: remove object size from tag count report

* tagging: ignore if cannot get lock

* ci: small fixups

* tagging: switch  to admin setting for tagging environment

* refactor: get object tag sync status count details separately

* refactor: tweak defaults and add tagging adhoc task spawn limit

* tests: reset static file storage before tests

* bugfix: fix test

* ci: fixup
@matthewhilton matthewhilton marked this pull request as ready for review December 6, 2024 05:37
@matthewhilton matthewhilton changed the title Add object tagging - Moodle 310 (#619) Add object tagging - Moodle 404 Dec 6, 2024
@matthewhilton matthewhilton merged commit c11315c into MOODLE_404_STABLE Dec 6, 2024
15 checks passed
@matthewhilton matthewhilton deleted the object-tagging-44 branch December 6, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant