Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(claude): init #1579

Open
wants to merge 47 commits into
base: main
Choose a base branch
from
Open

Conversation

ruiiiijiiiiang
Copy link

@ruiiiijiiiiang ruiiiijiiiiang commented Jan 14, 2025

🎉 Theme for Claude 🎉

Claude.ai, similar to ChatGPT, is an AI-powered chatbot and assistant developed by Anthropic, designed to provide conversational, creative, and problem-solving support. It focuses on generating helpful, safe, and user-aligned responses.

Latte with Peach

2025-01-14-121025_hyprshot

Frappe with Sapphire

2025-01-14-121535_hyprshot

Macchiato with Flamingo

2025-01-14-121625_hyprshot

Mocha with Mauve

2025-01-14-121421_hyprshot

🗒 Checklist 🗒

  • I have read and followed Catppuccin's submission guidelines.
  • I have made a new directory underneath /styles/<name-of-website> containing the contents of the /template directory.
    • I have ensured that the new directory is in lower-kebab-case.
    • I have followed the template and kept the preprocessor as LESS.
  • I have made sure to update the userstyles.yml file with information about the new userstyle.
  • I have included the following files:
    • catppuccin.user.less - all the CSS for the userstyle, based on the template.
    • preview.webp - composite image of all four individual flavor screenshots (taken with the default accent color of mauve) stitched together, generated via Catwalk.

@ruiiiijiiiiang ruiiiijiiiiang changed the title Feat/claude feat(claude): init Jan 14, 2025
uncenter

This comment was marked as outdated.

@uncenter

This comment was marked as outdated.

@uncenter uncenter added the waiting on author Note for staff that a re-review is not yet required label Feb 1, 2025
@ruiiiijiiiiang ruiiiijiiiiang requested a review from uncenter April 3, 2025 03:10
@uncenter

This comment was marked as resolved.

@ruiiiijiiiiang
Copy link
Author

@uncenter Updated:
image
image

@uncenter
Copy link
Member

uncenter commented Apr 3, 2025

CleanShot 2025-04-03 at 15 28 02

This delete button on hover has poor contrast, seems like they force a certain opacity so fading it like we normally do won't work afaik. Maybe just a button/class specific override?

@ruiiiijiiiiang
Copy link
Author

ruiiiijiiiiang commented Apr 3, 2025

CleanShot 2025-04-03 at 15 28 02

This delete button on hover has poor contrast, seems like they force a certain opacity so fading it like we normally do won't work afaik. Maybe just a button/class specific override?

I believe this is just danger-000 over danger-900, which is currently maroon over pink. What do you think is a good choice for their colors? I've tried:

    --danger-000: #hslify(darken(@maroon, 5%)) [];
    --danger-900: #hslify(lighten(@pink, 5%)) [];

and it looks like this:
image

@uncenter
Copy link
Member

uncenter commented Apr 3, 2025

fade(@red, 20%) maybe? And like I said I don't think we can change the variables because they force the opacity, we'll want to override the button with it's specific class.

@MathieuDR
Copy link

It's a pro feature IIRC.

Here is how it looks now

image
But when you hover over it
image

This is how the knowledge looks like

image

and when I select something
image

buttons html for if it's not available to you.

<div class="flex mt-3 gap-2 justify-end"><button class="inline-flex
  items-center
  justify-center
  relative
  shrink-0
  can-focus
  select-none
  disabled:pointer-events-none
  disabled:opacity-50
  disabled:shadow-none
  disabled:drop-shadow-none opacity-80
          transition-all
          active:scale-[0.985]
          hover:opacity-100
          hover:underline
          underline-offset-3 text-sm rounded-md text-accent-secondary-000 mr-2 !opacity-100 h-8" type="button">Select all</button>
<button class="inline-flex
  items-center
  justify-center
  relative
  shrink-0
  can-focus
  select-none
  disabled:pointer-events-none
  disabled:opacity-50
  disabled:shadow-none
  disabled:drop-shadow-none 
    text-text-000
    border-0.5
    border-border-300
    relative
    overflow-hidden
    font-styrene
    font-medium
    transition
    duration-100
    hover:border-border-300/0
    bg-bg-300/0
    hover:bg-bg-400
    backface-hidden h-8 rounded-md px-3 text-xs min-w-[4rem] active:scale-[0.985] whitespace-nowrap" type="button">Cancel</button>
<button class="inline-flex
  items-center
  justify-center
  relative
  shrink-0
  can-focus
  select-none
  disabled:pointer-events-none
  disabled:opacity-50
  disabled:shadow-none
  disabled:drop-shadow-none bg-danger-200
          text-oncolor-100
          font-styrene
          font-medium
          transition
          hover:scale-y-[1.015]
          hover:scale-x-[1.005]
          hover:opacity-95 h-8 rounded-md px-3 text-xs min-w-[4rem] active:scale-[0.985] whitespace-nowrap" type="button">Delete <span class="max-sm:hidden"> &nbsp;Selected</span></button></div>

Another small thing, the "select" is hard to read on the chats page

image
image

Hope that helps, keep up the good work!

@ruiiiijiiiiang
Copy link
Author

fade(@red, 20%) maybe? And like I said I don't think we can change the variables because they force the opacity, we'll want to override the button with it's specific class.

Okay I made a class specific override and it is indeed much better! ❤️
image

@ruiiiijiiiiang ruiiiijiiiiang requested a review from uncenter April 4, 2025 18:36
@uncenter
Copy link
Member

uncenter commented Apr 4, 2025

Button looks great, nice work. See also #1579 (comment), you may have missed my comment?

@ruiiiijiiiiang
Copy link
Author

It's a pro feature IIRC.

Here is how it looks now

image But when you hover over it image

This is how the knowledge looks like

image

and when I select something image

buttons html for if it's not available to you.

<div class="flex mt-3 gap-2 justify-end"><button class="inline-flex
  items-center
  justify-center
  relative
  shrink-0
  can-focus
  select-none
  disabled:pointer-events-none
  disabled:opacity-50
  disabled:shadow-none
  disabled:drop-shadow-none opacity-80
          transition-all
          active:scale-[0.985]
          hover:opacity-100
          hover:underline
          underline-offset-3 text-sm rounded-md text-accent-secondary-000 mr-2 !opacity-100 h-8" type="button">Select all</button>
<button class="inline-flex
  items-center
  justify-center
  relative
  shrink-0
  can-focus
  select-none
  disabled:pointer-events-none
  disabled:opacity-50
  disabled:shadow-none
  disabled:drop-shadow-none 
    text-text-000
    border-0.5
    border-border-300
    relative
    overflow-hidden
    font-styrene
    font-medium
    transition
    duration-100
    hover:border-border-300/0
    bg-bg-300/0
    hover:bg-bg-400
    backface-hidden h-8 rounded-md px-3 text-xs min-w-[4rem] active:scale-[0.985] whitespace-nowrap" type="button">Cancel</button>
<button class="inline-flex
  items-center
  justify-center
  relative
  shrink-0
  can-focus
  select-none
  disabled:pointer-events-none
  disabled:opacity-50
  disabled:shadow-none
  disabled:drop-shadow-none bg-danger-200
          text-oncolor-100
          font-styrene
          font-medium
          transition
          hover:scale-y-[1.015]
          hover:scale-x-[1.005]
          hover:opacity-95 h-8 rounded-md px-3 text-xs min-w-[4rem] active:scale-[0.985] whitespace-nowrap" type="button">Delete <span class="max-sm:hidden"> &nbsp;Selected</span></button></div>

Another small thing, the "select" is hard to read on the chats page

image image

Hope that helps, keep up the good work!

Looks like the dark text is colored with accent-secondary-000, which was previously set to @crust. I've updated it to use @accent instead. Can you try with the latest commit?

@uncenter
Copy link
Member

uncenter commented Apr 4, 2025

Settings > Billing has this page with two buttons with low contrast text.

CleanShot 2025-04-04 at 14 53 31

This snippet of CSS is the culprit.

.text-always-white {
    --tw-text-opacity: 1;
    color: hsl(var(--always-white)/var(--tw-text-opacity));
}

So I think we can just theme --always-white and have it fixed :)


That is it for comments from me, only the unthemed pro features are blocking atm.

@MathieuDR
Copy link

Looks like the dark text is colored with accent-secondary-000, which was previously set to @crust. I've updated it to use @accent instead. Can you try with the latest commit?

Everything looks good now!

The only 'issue' i found is that the checkbox on the chats is hard to see

image

@ruiiiijiiiiang
Copy link
Author

Settings > Billing has this page with two buttons with low contrast text.

CleanShot 2025-04-04 at 14 53 31

This snippet of CSS is the culprit.

.text-always-white {
    --tw-text-opacity: 1;
    color: hsl(var(--always-white)/var(--tw-text-opacity));
}

So I think we can just theme --always-white and have it fixed :)

That is it for comments from me, only the unthemed pro features are blocking atm.

Button fixed:
image
I also added a few overrides for the "upgrade to pro" page, which had a few low contrast elements because of the accents:
image

@ruiiiijiiiiang
Copy link
Author

Looks like the dark text is colored with accent-secondary-000, which was previously set to @crust. I've updated it to use @accent instead. Can you try with the latest commit?

Everything looks good now!

The only 'issue' i found is that the checkbox on the chats is hard to see

image

Can you please share the html for that button including the checkbox?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants