Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(google): add a lot of styles to ogs, use and add gm3 tokens for modern component styling #1680

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

WalkQuackBack
Copy link
Member

@WalkQuackBack WalkQuackBack commented Mar 26, 2025

🔧 What does this fix? 🔧

As of now, the ogs Google dialogue is not themed very consistently and a lot of elements are unthemed.

Before:

Screenshot 2025-03-26 164723
Colour on focused border and elevated card background

Screenshot 2025-03-26 164915
Accent colour, state layer on hairline/outlined button, accent colour, state layer, background on tonal button, accent colour on icons, background and text on badges, text on dismiss icon

After:

image

image

This refactor attempts to make styling more consistent by directly using and modifying the CSS bundles that are provided by Google, decreasing the chance that styles are missed and making the look more consistent.

🗒 Checklist 🗒

@github-actions github-actions bot added the google Google label Mar 26, 2025
@WalkQuackBack WalkQuackBack requested a review from uncenter March 27, 2025 15:25
@WalkQuackBack WalkQuackBack reopened this Apr 5, 2025
@WalkQuackBack WalkQuackBack marked this pull request as draft April 5, 2025 01:10
@WalkQuackBack
Copy link
Member Author

Waiting on decision of how organization handles Google userstyles.

@uncenter uncenter added the pending Pending due to internal discussion, planned website updates, etc. label Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
google Google pending Pending due to internal discussion, planned website updates, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants