Comments & organization of app code #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
August 21, 2023 17:17
| # locs <- read_csv("Lat_long_AFSshiny_012023.csv") %>% | ||
| # select(-date) # not parseable as is | ||
|
|
||
| locs <- read_csv("toy_locs.csv") %>% |
There was a problem hiding this comment.
Would it be more useful to change this logic to read in the real location file Lat_long_AFSshiny_012023.csv, then if that's not available to read in the toy one?
|
Other than my one comment about reading in location data, I think this looks good! Having all of these comments and structure is super useful. I am going to wait until you implement that change @diazrenata and then I'll test the code locally to make sure everything works and merge this. |
…you have to switch it). Also fix typo in ggplot on line 730 and remove review_notes.md from what would get merged upstream.
|
@KristinaRiemer I toggled the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See diazrenata#1