-
Notifications
You must be signed in to change notification settings - Fork 470
Update import handling for cron_descriptor > 2.0.x compatibility # 934 Real Fix #936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #936 +/- ##
==========================================
- Coverage 88.18% 87.25% -0.93%
==========================================
Files 32 32
Lines 1007 1012 +5
Branches 105 81 -24
==========================================
- Hits 888 883 -5
- Misses 101 111 +10
Partials 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
from cron_descriptor import (FormatException, MissingFieldException, | ||
WrongArgumentException, get_description) | ||
|
||
try: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try: | |
try: # Python >= 3.11 can use cron_descriptor >= 2.0 which uses *Error exceptions. |
We need a comment here explaining why.
Or perhaps in #935 we should just pin the dependency to >= 2.0 and just use *Error instead of try
/ except
.
EDIT: #938 proves that the above suggestion will not work. We need try
/ except
because cron_descriptor
v2 only supports Python >= v3.11.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cron_descriptor 2.0.5 supports Python 3.9 - 3.13...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check the test failures please
Add comment per request Co-authored-by: Christian Clauss <cclauss@me.com>
Addresses final fixes for #934
Fixes #934
Fixes #935
Fixes #937
Fixes #938