Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add about us page #18

Closed
wants to merge 1 commit into from
Closed

feat: add about us page #18

wants to merge 1 commit into from

Conversation

rafaellseara
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Oct 23, 2023

Deploy Preview for cesium-hydrogen-new ready!

Name Link
🔨 Latest commit e65bcd9
🔍 Latest deploy log https://app.netlify.com/sites/cesium-hydrogen-new/deploys/6536b2d4f209550008d3d690
😎 Deploy Preview https://deploy-preview-18--cesium-hydrogen-new.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@ruioliveira02 ruioliveira02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is just a draft, but I am reviewing so you get more immediate feedback.

As I have already told you, overall it is pretty good, you just need to fix some issues with responsiveness, and the things I have pointed out.

As far as design goes, I think it is following the visual identity very well, but that is not my call to make.

Keep up the good work 🙏

@@ -0,0 +1,58 @@
import React from "react";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import React from "react";

This is not needed in Next.js

@@ -0,0 +1,58 @@
import React from "react";

export default function about_us() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export default function about_us() {
export default function AboutUs() {

The naming convention is to use Pascal Case.

@@ -17,7 +17,7 @@ export default function Navbar() {
<Link
key={title}
className={`transition-colors hover:border-cesium-900 hover:text-cesium-900`}
href={`/${title.toLowerCase()}`}
href={`/${title.toLowerCase().replace(/\s+/g, "_")}`}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
href={`/${title.toLowerCase().replace(/\s+/g, "_")}`}
href={`/${title.replace(/\s+/g, "")}`}

This needs to be updated to match the naming convention above.

@@ -21,7 +21,7 @@
"autoprefixer": "10.4.14",
"eslint": "8.42.0",
"eslint-config-next": "13.4.4",
"next": "13.4.4",
"next": "^13.4.4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason for this change? I don't think it is necessary

</div>
<div className="mt-20 flex select-none flex-col">
<h1 className="text-center font-orbitron text-3xl font-semibold underline decoration-cesium-900">
About Us
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it makes sense to be mixing Portuguese and English.

@diogogmatos
Copy link
Member

Closed due to integral project changes both in planning and structure, #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants