usbd: Remove debug prints and add an example for the V203 #94
Conversation
The driver works for the most part, except you must for some reason use the arch-spin executor to make it work. Perhaps something is wrong in the interrupts? Do not merge in the current form!
| // It needs some buffers for building the descriptors. | ||
| let mut config_descriptor = [0; 256]; | ||
| let mut bos_descriptor = [0; 256]; | ||
| let mut msos_descriptor = [0; 256]; |
There was a problem hiding this comment.
If no msos descriptor is used, this buffer should be [0; 0]
There was a problem hiding this comment.
Thanks for these changes.
I have tested the example on a CH32V203C8T6 board (WeActStudio).
It works as expected but to work without the WCH-Link connected, I had to comment the println! statement otherwise it enumerates but picocom was stuck on connection.
Once the minor comments are addressed, this can be merged.
I think that the use of arch-spin is not blocking.
| config.manufacturer = Some("Embassy"); | ||
| config.product = Some("USB-serial example"); | ||
| config.serial_number = Some("12345678"); | ||
| config.max_power = 100; |
There was a problem hiding this comment.
This is the default value, this line can be omitted.
| config.product = Some("USB-serial example"); | ||
| config.serial_number = Some("12345678"); | ||
| config.max_power = 100; | ||
| config.max_packet_size_0 = 64; |
There was a problem hiding this comment.
This is the default value, this line can be omitted.
| // It needs some buffers for building the descriptors. | ||
| let mut config_descriptor = [0; 256]; | ||
| let mut bos_descriptor = [0; 256]; | ||
| let mut msos_descriptor = [0; 256]; |
There was a problem hiding this comment.
This variable is not used, this line can be omitted.
| bind_interrupts!(struct Irqs { | ||
| USB_LP_CAN1_RX0 => hal::usbd::InterruptHandler<hal::peripherals::USBD>; | ||
| }); | ||
|
|
There was a problem hiding this comment.
Maybe add a comment that the println! lines should be commented to work properly without a probe connected.
|
Is anyone working on getting this merged? I could probably pick it up some time this month if @Noxime dose not have time to finish getting it merged. |
|
the use of arch-spin is intentional we can't use the riscv arch because it uses wfi which is not really compatible with the usb peripheral (broken HW implementation on WCH's part, I have discussed this with their support engineer) If anyone want to get the conflicts / small fixes resolved I would be happy to get this merged. |
Do not merge before fixing the executor issue!
The driver works for the most part, except you must for some reason use the arch-spin executor to make it work. Perhaps something is wrong in the interrupts? I have no experience with embassy executor internals or the USB peripheral itself, so any help would be appreciated.
@andelf Do you have any ideas?
Closes #79