Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CUDA hello example and compilation with HAPI_TRACE #3769

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Conversation

minitu
Copy link
Contributor

@minitu minitu commented Oct 10, 2023

Still needs a way to pass HAPI_TRACE as defined to the header and source files in src/arch/cuda/hybridAPI.
I think this can be done by modifying the CMakeLists.txt (and maybe a couple of other places), but would need help from the Charm++ folks.

@minitu minitu requested a review from trquinn October 10, 2023 21:19
@minitu minitu requested a review from matthiasdiener October 10, 2023 21:24
@matthiasdiener
Copy link
Contributor

Something like this in the main CMakeLists.txt might work, adding after line https://github.com/UIUC-PPL/charm/blob/520585628155479ae7f50df671e21fc084274a46/CMakeLists.txt#L705:

if(TRACING)
  target_compile_definitions(cudahybridapi PRIVATE HAPI_TRACE)
endif()

@minitu
Copy link
Contributor Author

minitu commented Oct 10, 2023

@matthiasdiener Confirmed that does the right thing. Thanks!

Copy link
Collaborator

@trquinn trquinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with changa w/ projections: it runs now.

@trquinn trquinn added this pull request to the merge queue Oct 11, 2023
Merged via the queue into main with commit cdaacf7 Oct 11, 2023
17 checks passed
@stwhite91 stwhite91 deleted the jchoi/hapi-trace branch July 25, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants