fixes to allow mac builds to work smoothly #248
Conversation
add arm build fix to ray branch
|
I think this should be merged now, with the fix made here: charmplusplus/charm#3797 |
|
I added changes to the charm4py install documentation to put the current working build procedure first. Additionally, as Sanjay said in the 4/1 Charm4py meeting, any fixes to the implicit function warnings should be part of another pr. |
docs/install.rst
Outdated
| @@ -72,25 +76,24 @@ and run setup:: | |||
| to manually build the Charm++ library (see below). | |||
|
|
|||
|
|
|||
| Manually building the Charm++ shared library | |||
| -------------------------------------------- | |||
| pip (Python 3.7 and older) | |||
There was a problem hiding this comment.
pip works for newer Python versions too. Just that pip3 install charm4py will build from source instead of getting prebuilt binaries
|
I added an OS call to fix the path in the c_object_store shared object file. it's just a workaround/hack for now |
|
We should check that this also works for Apple Silicon macs... @mayantaylor can you confirm? |
|
@ritvikrao Can you make these changes on top of the main branch so that my commits from the ray branch don't show up |
I made a couple of changes to allow the charm4py build on macs to work smoothly. Note that this only solves the issues that arise after a successful charm++ install has happened; there's an ongoing pr in the charm++ repo to fix charm4py installation issues there.
The first change adds a flag in setup.py to ignore implicit function declaration errors that show up with newer versions of Apple Clang (15.0.0 and up). The second change modifies charm4py/charmlib/ctypes_py to specify that the charm++ library file created by mac builds is libcharm.dylib, not libcharm.so.