fix: Encrypt broadcast list in PGP-contacts migration #6858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iequidoo
reviewed
May 20, 2025
| *original, | ||
| autocrypt_pgp_contacts | ||
| .get(original) | ||
| // TODO it's unclear whether we want to do this: |
There was a problem hiding this comment.
Btw, can we retain address contacts in encrypted groups, but just send messages to PGP contacts? Then if we learn the contact's key later, the problem goes away. We still can add some info message and anyway, sending a message doesn't guarantee its receipt even for a PGP contact
| ) | ||
| }) | ||
| .collect() | ||
| retain_autocrypt_pgp_contacts() | ||
| } | ||
| } | ||
|
|
||
| // Mailinglist | Broadcast list |
There was a problem hiding this comment.
"Broadcast list" should be moved down
link2xt
force-pushed
the
link2xt/pgp-contacts
branch
from
1cc8e8b to
dff076c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.