Skip to content

Commit

Permalink
Merge pull request #323 from BlythMeister/MyBetaVersion
Browse files Browse the repository at this point in the history
Fix #322 added a "filler" which is present when hiding images on account...
  • Loading branch information
BlythMeister committed Sep 27, 2013
2 parents 6cd546b + d08c5df commit 37a616c
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 1 deletion.
2 changes: 1 addition & 1 deletion android/clientbeta/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.tweetlanes.android.beta"
android:versionCode="51"
android:versionName="1.2.1_b7">
android:versionName="1.2.1_b8">



Expand Down
7 changes: 7 additions & 0 deletions android/libraries/TweetLanesCore/res/layout/account_row.xml
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,11 @@
android:text="ScreenName"
android:textSize="@dimen/account_row_size"
android:layout_marginLeft="10dp"/>

<TextView
android:id="@+id/filler"
android:layout_width="1px"
android:layout_height="48dp"
android:adjustViewBounds="true"
/>
</LinearLayout>
Original file line number Diff line number Diff line change
Expand Up @@ -814,6 +814,7 @@ public View getView(int position, View convertView, ViewGroup parent) {
holder.AvatarImage = (ImageView) row.findViewById(R.id.accountAvatar);
holder.ServiceImage = (ImageView) row.findViewById(R.id.serviceImage);
holder.ScreenName = (TextView) row.findViewById(R.id.accountScreenName);
holder.Filler = (TextView) row.findViewById(R.id.filler);

row.setTag(holder);
} else {
Expand All @@ -833,9 +834,11 @@ public View getView(int position, View convertView, ViewGroup parent) {

if (mShowImages) {
setProfileImage(account.AvatarImageUrl, account.ServiceType, holder.AvatarImage, holder.ServiceImage);
holder.Filler.setVisibility(View.GONE);
} else {
holder.AvatarImage.setVisibility(View.GONE);
holder.ServiceImage.setVisibility(View.GONE);
holder.Filler.setVisibility(View.VISIBLE);
}

return row;
Expand All @@ -859,6 +862,7 @@ class AccountHolder {
public ImageView AvatarImage;
public ImageView ServiceImage;
public TextView ScreenName;
public TextView Filler;
}

private void setProfileImage(String profileImageUrl, SocialNetConstant.Type serviceType, ImageView avatar, ImageView service) {
Expand Down

0 comments on commit 37a616c

Please sign in to comment.