feat(): fix list returned

chutney-testing · Jan 15, 2024 · 2ae219d · 2ae219d
1 parent 1c68b8d
commit 2ae219d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/engine/src/main/java/com/chutneytesting/engine/domain/execution/engine/step/Step.java b/engine/src/main/java/com/chutneytesting/engine/domain/execution/engine/step/Step.java
@@ -43,7 +43,7 @@
 import com.google.common.collect.Maps;
 import java.time.Duration;
 import java.time.Instant;
-import java.util.ArrayList;
+import java.util.Collections;
 import java.util.HashMap;
 import java.util.LinkedHashMap;
 import java.util.List;
@@ -248,7 +248,7 @@ public String type() {
     }
 
     public List<Step> subSteps() {
-        return new ArrayList<>(steps);
+        return Collections.unmodifiableList(steps);
     }
 
     public StepExecutor executor() {

diff --git a/.../src/main/java/com/chutneytesting/engine/domain/execution/strategies/ForEachStrategy.java b/.../src/main/java/com/chutneytesting/engine/domain/execution/strategies/ForEachStrategy.java
@@ -125,7 +125,7 @@ private Pair<Step, Map<String, Object>> buildIteration(String indexName, Integer
 
     private Step buildIterationDefinition(String indexName, Integer index, StepDataEvaluator dataEvaluator, StepDefinition definition, StepExecutor executor, List<Step> subStep, StepStrategyDefinition strategy) {
         StepDefinition iterationDefinition = iterationDefinition(indexName, index, definition, Optional.ofNullable(strategy).orElse(new StepStrategyDefinition("", new StrategyProperties())));
-        return new Step(dataEvaluator, iterationDefinition, executor, subStep.stream().map(step -> buildIterationDefinition(indexName, index, step.dataEvaluator(), step.definition(), step.executor(), step.subSteps(), step.strategy().orElse(null))).collect(Collectors.toList()));
+        return new Step(dataEvaluator, iterationDefinition, executor, subStep.stream().map(step -> buildIterationDefinition(indexName, index, step.dataEvaluator(), step.definition(), step.executor(), step.subSteps(), step.strategy().orElse(null))).toList());
     }
 
     private StepDefinition iterationDefinition(String indexName, Integer index, StepDefinition definition, StepStrategyDefinition strategyDefinition) {