Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add usage tips to README #334

Merged

Conversation

ulrikandersen
Copy link
Collaborator

This PR aims to enhance the Fabrikt README by adding helpful pointers to ensure users can get the most out of the tool 🚀.

There are a few well-known gotchas that have been raised in issues, so we thought it would be valuable to document them here. This should reduce the chances of users giving up on Fabrikt with the impression that “It’s not working!” and instead help them troubleshoot effectively.

Any other gotchas worth mentioning?

Cc/ @cjbooms, @acanda, @averabaq, ..?

Copy link
Owner

@cjbooms cjbooms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I immediately looked to see if you had covered anything about inline generation. So delighted to see these additions

README.md Outdated

While inline schemas are perfectly valid they are not supported by Fabrikt in all circumstances.
This is especially true for request bodies and non-trivial parameters. Instead, define your schemas in the
components section of the OpenAPI spec (`components.parameters` & `components.requestBodies`).
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uneeded line break

@cjbooms cjbooms merged commit 028e93a into cjbooms:master Nov 27, 2024
1 check passed
@ulrikandersen ulrikandersen deleted the readme-getting-the-most-from-fabrikt branch November 27, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants