Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace the hardcoded filename with correct filename #3957

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

tabraiz12
Copy link
Collaborator

What changes were proposed in this pull request?

As part of removing csp with inline javascript, a filename was hardcoded by mistake, this has been fixed

file-display-inline.js#67 instead has an hardcoded /user/admin/ai_case.txt path used

Fixes: #3956

How was this patch tested?

  • This has been tested manually

Please review Hue Contributing Guide before opening a pull request.

Copy link

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

Copy link
Collaborator

@ramprasadagarwal ramprasadagarwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tabraiz12 tabraiz12 merged commit a178e77 into master Jan 15, 2025
6 checks passed
@tabraiz12 tabraiz12 deleted the filebrowser-inline-js-issue branch January 15, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File display broken following inlining changes
3 participants