[v8] Add lifecycle flag to buildpacks related commands #3496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomkennedy513
force-pushed
the
lifecycle-flag-v8
branch
3 times, most recently
from
3706ee6 to
4cc0e56
Compare
tomkennedy513
changed the title
tomkennedy513
force-pushed
the
lifecycle-flag-v8
branch
2 times, most recently
from
72e5374 to
d9b37fc
Compare
Samze
reviewed
Apr 29, 2025
tomkennedy513
force-pushed
the
lifecycle-flag-v8
branch
from
d9b37fc to
9a4496f
Compare
Samze
reviewed
Apr 29, 2025
| queries := []ccv3.Query{ccv3.Query{Key: ccv3.OrderBy, Values: []string{ccv3.PositionOrder}}} | ||
| if labelSelector != "" { | ||
| queries = append(queries, ccv3.Query{Key: ccv3.LabelSelectorFilter, Values: []string{labelSelector}}) | ||
| } | ||
|
|
||
| if lifecycle != "" { |
There was a problem hiding this comment.
question What happens when specifying this flag against an older CAPI without cloudfoundry/cloud_controller_ng#3898 ? Ideally it should fail gracefully. We may need a guard like https://github.com/cloudfoundry/cli/blob/main/command/v7/push_command.go#L583
There was a problem hiding this comment.
left it at the next patch version for now, will adjust if needed when the version is released
|
Note This PR should not be merged before cloudfoundry/cloud_controller_ng#3898 is merged and in a CAPI release |
Signed-off-by: Tom Kennedy <tom.kennedy@broadcom.com>
- This will allow capi to update the default order independently of the cli in the future Signed-off-by: Tom Kennedy <tom.kennedy@broadcom.com>
tomkennedy513
commented
Apr 30, 2025
tomkennedy513
force-pushed
the
lifecycle-flag-v8
branch
from
7a325b3 to
9f2ae06
Compare
tomkennedy513
changed the title
tomkennedy513
force-pushed
the
lifecycle-flag-v8
branch
4 times, most recently
from
732f08a to
2c290de
Compare
Signed-off-by: Tom Kennedy <tom.kennedy@broadcom.com>
Signed-off-by: Tom Kennedy <tom.kennedy@broadcom.com>
tomkennedy513
force-pushed
the
lifecycle-flag-v8
branch
from
2c290de to
0896070
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This adds the a lifecycle flag to cf buildpacks and cf create-buildpack to support cnb. This makes use of the changes in cloudfoundry/cloud_controller_ng#3898.
Why Is This PR Valuable?
Without this change there is no way to create buildpacks with non default lifecycles
Applicable Issues
List any applicable GitHub Issues here
How Urgent Is The Change?
This change should be merged right after cloudfoundry/cloud_controller_ng#3898 to allow folks to use that feature.
Other Relevant Parties
Who else is affected by the change?