[main] Add lifecycle flag to buildpacks related commands #3497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomkennedy513
changed the title
tomkennedy513
force-pushed
the
lifecycle-flag
branch
6 times, most recently
from
f18c5ee to
32b43c7
Compare
Signed-off-by: Tom Kennedy <tom.kennedy@broadcom.com>
- This will allow capi to update the default order independently of the cli in the future Signed-off-by: Tom Kennedy <tom.kennedy@broadcom.com>
tomkennedy513
changed the title
tomkennedy513
force-pushed
the
lifecycle-flag
branch
2 times, most recently
from
9ec63b8 to
7094f26
Compare
Signed-off-by: Tom Kennedy <tom.kennedy@broadcom.com>
Signed-off-by: Tom Kennedy <tom.kennedy@broadcom.com>
tomkennedy513
force-pushed
the
lifecycle-flag
branch
from
7094f26 to
aee3038
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This adds the a lifecycle flag to cf buildpacks and cf create-buildpack to support cnb. This makes use of the changes in cloudfoundry/cloud_controller_ng#3898.
Why Is This PR Valuable?
Without this change there is no way to create buildpacks with non default lifecycles
Applicable Issues
List any applicable GitHub Issues here
How Urgent Is The Change?
This change should be merged right after cloudfoundry/cloud_controller_ng#3898 to allow folks to use that feature.
Other Relevant Parties
Who else is affected by the change?