Skip to content

Add Perses dashboards and related configurations #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 14, 2025

Conversation

ibakshay
Copy link
Contributor

Signed-off-by: Akshay Iyyadurai Balasundaram akshay.iyyadurai.balasundaram@sap.com

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

  • Related Issue # (issue)
  • Closes # (issue)
  • Fixes # (issue)

Remove if not applicable

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

- Introduced a new project configuration for Perses dashboards in `project.json`.
- Added a comprehensive dashboard configuration for Prometheus details in `prometheus-details.json`.
- Updated `_helpers.tpl` to include a new function for Perses dashboard selector labels.
- Created a new template file `perses-dashboards.yaml` to generate ConfigMaps for Perses dashboards.
- Enhanced `values.yaml` to include label selectors for Perses dashboards.

Signed-off-by: Akshay Iyyadurai Balasundaram <akshay.iyyadurai.balasundaram@sap.com>
@ibakshay ibakshay requested review from a team as code owners May 12, 2025 10:46
ibakshay added 2 commits May 12, 2025 12:48
* Renamed panels for clarity:
  - Changed `HTTP Requests Latency` to `HTTP Requests Rate`.
  - Updated descriptions to accurately reflect the metrics displayed.
* Adjusted Prometheus queries to align with new metrics.
* Enhanced visual settings for better data representation.

Signed-off-by: Akshay Iyyadurai Balasundaram <akshay.iyyadurai.balasundaram@sap.com>
* Enhanced the project description to include both Plutono and Perses dashboards.
* Added a new section for `perses-dashboards` in the content structure.
* Introduced `dashboards.persesSelectors` in the values table for better configuration.

Signed-off-by: Akshay Iyyadurai Balasundaram <akshay.iyyadurai.balasundaram@sap.com>
Copy link
Member

@richardtief richardtief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks for moving them over.

ibakshay added 2 commits May 12, 2025 14:38
* Updated the version number in `Chart.yaml` to reflect the latest release.

Signed-off-by: Akshay Iyyadurai Balasundaram <akshay.iyyadurai.balasundaram@sap.com>
Copy link
Member

@richardtief richardtief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two dashboards can be part of their origin.

…rations charts

Signed-off-by: Akshay Iyyadurai Balasundaram <akshay.iyyadurai.balasundaram@sap.com>
@ibakshay
Copy link
Contributor Author

@richardtief Thank you very much for the suggestion. I have removed both the Perses and Prometheus self-monitoring dashboards from this repository and added directly to the greenhouse-extensions repository in this PR - cloudoperators/greenhouse-extensions#858

@ibakshay ibakshay merged commit 29ee0b4 into main May 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants