Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add service name for hertz and remove kitex unused config #193

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

rogerogers
Copy link
Collaborator

@rogerogers rogerogers commented Jun 11, 2024

What type of PR is this?

What this PR does / why we need it (en: English/zh: Chinese):

en:
zh: hertz 增加一个 servicename,删除 kitex 配置结构体中无用的部分

Which issue(s) this PR fixes:

Signed-off-by: rogerogers <rogers@rogerogers.com>
Copy link
Collaborator

@Skyenought Skyenought left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@li-jin-gou li-jin-gou merged commit f95a304 into cloudwego:main Jun 14, 2024
5 checks passed
@rogerogers rogerogers deleted the chore/template branch June 14, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants