-
-
Notifications
You must be signed in to change notification settings - Fork 90
Performance Improvements #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Asachoo
wants to merge
8
commits into
cmars:master
Choose a base branch
from
Asachoo:speed_up
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4f53b31
refactor: optimize getFieldParser and createRecordParser methods.
Asachoo 7052368
style: Fix field resolver cache initialization position.
Asachoo 5eac172
style: fix regular expression quote format.
Asachoo 369e0a3
feat: Add memorize decorator to cache fieldType results.
Asachoo 6742053
fix(IO): simplify field parsing logic.
Asachoo b498057
feat: Add batch reading field function.
Asachoo 534154a
fix(Parser): fix the logic of reading fields and batch reading fields.
Asachoo 3d028a4
Merge branch 'cmars:master' into speed_up
Asachoo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a change in behavior [swallowing the end of record exception, I mean]. Why was this added? Could it subtly change the behavior of how the parser is used in an unexpected way? I'm concerned that it might... can you provide more context here to derisk that concern?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that the addition of the
EndOfRecordException
exception handling in thecreateRecordParser
method originates from the originalappendFieldParser
method.The original
appendFieldParser
method served the purpose of organizing the order of actions and handling exceptions.Now, the
memorize
decorator only provides the caching functionality. The organization of actions and exception handling have been moved to thecreateRecordParser
method (the original caller ofappendFieldParser
) for explicit implementation.