Skip to content

Commit

Permalink
tests-scan: Add "image-download" secret
Browse files Browse the repository at this point in the history
So that job containers can download private images (RHEL). This secret
gets defined in cockpit-project/cockpituous#594
  • Loading branch information
martinpitt committed Mar 11, 2024
1 parent 39f7a36 commit a07a0bb
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions test/test_tests_scan.py
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ def test_amqp_pr(self, mock_queue, _mock_strftime):
"slug": f"pull-{self.pull_number}-abcdef-20240102-030405-fedora-nightly",
"target": "stable-1.0",
"container": "supertasks",
"secrets": ["github-token"],
"secrets": ["github-token", "image-download"],
"env": {
"BASE_BRANCH": "stable-1.0",
"COCKPIT_BOTS_REF": "main",
Expand Down Expand Up @@ -338,7 +338,7 @@ def test_amqp_sha_nightly(self, mock_queue, _mock_strftime):
},
# project/repo doesn't have a custom container name file
"container": None,
"secrets": ["github-token"],
"secrets": ["github-token", "image-download"],
"env": {
"COCKPIT_BOTS_REF": "main",
"TEST_OS": "fedora",
Expand Down Expand Up @@ -389,7 +389,7 @@ def test_amqp_sha_pr(self, mock_queue, _mock_strftime):
"slug": f"pull-{self.pull_number}-abcdef-20240102-030405-fedora-nightly",
"target": "stable-1.0",
"container": "supertasks",
"secrets": ["github-token"],
"secrets": ["github-token", "image-download"],
"env": {
"BASE_BRANCH": "stable-1.0",
"COCKPIT_BOTS_REF": "main",
Expand Down
4 changes: 2 additions & 2 deletions tests-scan
Original file line number Diff line number Diff line change
Expand Up @@ -235,8 +235,8 @@ def queue_test(job: Job, channel, options: argparse.Namespace) -> None:
"slug": slug,
"env": env,
"container": job.container,
# for updating naughty trackers
"secrets": ["github-token"],
# for updating naughty trackers and downloading private images
"secrets": ["github-token", "image-download"],
}
}

Expand Down

0 comments on commit a07a0bb

Please sign in to comment.