Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: Replace deprecated :set-output #6024

Merged
merged 2 commits into from
Mar 6, 2024
Merged

workflows: Replace deprecated :set-output #6024

merged 2 commits into from
Mar 6, 2024

Conversation

martinpitt
Copy link
Member

This causes a "will soon be removed" warning, see
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/


This is also included in cockpit-project/cockpituous#587 where it covers the "positive" case of a changed repo with a container rebuild. Here it should not run cockpituous test.

@martinpitt
Copy link
Member Author

Haha, I involuntarily tested the positive case here, as we currently consider workflow changes to affect the deployment. That is nonsense, I'll fix that in a separate commit.

@martinpitt
Copy link
Member Author

With the second commit, it doesn't run cockpituous, so we have coverage for both cases.

@martinpitt martinpitt requested a review from jelly March 6, 2024 04:42
@jelly jelly merged commit 5c71fef into main Mar 6, 2024
5 checks passed
@jelly jelly deleted the drop-set-output branch March 6, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants