-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pyproject.toml: stop linting in venvs #20154
Merged
allisonkarlitskaya
merged 1 commit into
cockpit-project:main
from
allisonkarlitskaya:dont-lint-in-venv
Mar 11, 2024
Merged
pyproject.toml: stop linting in venvs #20154
allisonkarlitskaya
merged 1 commit into
cockpit-project:main
from
allisonkarlitskaya:dont-lint-in-venv
Mar 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the unit-tests run:
OK, so good — ruff caught one of the problems, but clearly mypy missed the other 😅 Let's get mypy in the tasks container, then. |
|
better, but oops: vulture. |
good! |
Lacking a proper requirements.txt file, we're at the mercy of whatever got randomly uploaded to pypy last night, and we've been seeing a lot of breaks lately. We already run our ruff/mypy/etc. stuff as part of our unit tests workflow, so let's stop running it in venv. The idea is that we should pass against the current version of the tasks container (which will probably shift at some point to being our pinned version of the tasks container). While we're at it, drop Python 3.7 (which the world seems to have collectively decided to stop caring about) and add Python 3.13 (which has been in Fedora 39 for a while already). Note: we do *not* drop Python 3.6 — although it is no longer an officially supported release, it's used in RHEL 7 and RHEL 8 and Fedora intends to keep packaging it.
f9147f3
to
8c71585
Compare
martinpitt
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
dada0dc
into
cockpit-project:main
30 of 31 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lacking a proper requirements.txt file, we're at the mercy of whatever
got randomly uploaded to pypy last night, and we've been seeing a lot of
breaks lately.
We already run our ruff/mypy/etc. stuff as part of our unit tests
workflow, so let's stop running it in venv. The idea is that we should
pass against the current version of the tasks container (which will
probably shift at some point to being our pinned version of the tasks
container).
While we're at it, drop Python 3.7 (which the world seems to have
collectively decided to stop caring about) and add Python 3.13 (which
has been in Fedora 39 for a while already). Note: we do not drop
Python 3.6 — although it is no longer an officially supported release,
it's used in RHEL 7 and RHEL 8 and Fedora intends to keep packaging it.