shell: More types than ever #21426
Merged
shell: More types than ever #21426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvollmer
added
the
blocked
|
This is still another approach, just rename everything (almost) and get it relaxed green. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
martinpitt
removed
the
blocked
|
@mvollmer unblocked! |
mvollmer
force-pushed
the
shell-typing-4
branch
3 times, most recently
from
7fb1850 to
f9267bb
Compare
A CockpitNav component wants the "filtering" function to put a keyword on each item, but the item can be anything otherwise. CockpitHosts uses it with Machine objects, and PageNav with ManifestItems.
mvollmer
force-pushed
the
shell-typing-4
branch
from
f9267bb to
c29bed6
Compare
martinpitt
requested changes
Jan 7, 2025
It can return null and the host parameter is optional.
mvollmer
force-pushed
the
shell-typing-4
branch
from
c29bed6 to
f2bcc1e
Compare
cockpituous
reviewed
Jan 8, 2025
| useEvent(keys as unknown as cockpit.EventSource<cockpit.EventMap>, "changed"); | ||
|
|
||
| if (!keys) | ||
| return null; |
There was a problem hiding this comment.
This added line is not executed by any test.
| setUnlockKey(key.name); | ||
| /* Key needs to be unloaded, do that directly */ | ||
| } else if (!enable && key.loaded) { | ||
| keys.unload(key).catch(ex => setDialogError(ex.message)); |
There was a problem hiding this comment.
This added line is not executed by any test.
| onClose={() => dialogResult.resolve()} | ||
| title={_("SSH keys")} | ||
| id="credentials-modal" | ||
| footer={<Button variant='secondary' onClick={() => dialogResult.resolve()}>{_("Close")}</Button>} |
There was a problem hiding this comment.
This added line is not executed by any test.
| footer={<Button variant='secondary' onClick={() => dialogResult.resolve()}>{_("Close")}</Button>} | ||
| > | ||
| <Stack hasGutter> | ||
| {dialogError && <ModalError dialogError={dialogError} />} |
There was a problem hiding this comment.
This added line is not executed by any test.
| { title: _("Toggle") }, | ||
| ] } | ||
| rows={ Object.keys(keys.items).map((currentKeyId, index) => { | ||
| const currentKey = keys.items[currentKeyId] || { name: 'test' }; |
There was a problem hiding this comment.
This added line is not executed by any test.
Comment on lines
+71
to
+72
| onTroubleshoot = () => {}, | ||
| onReconnect = () => {}, |
There was a problem hiding this comment.
These 2 added lines are not executed by any test.
| @@ -202,8 +235,8 @@ export class CockpitHosts extends React.Component { | |||
| </Tooltip> | |||
| </>} | |||
| />; | |||
| const label = current_machine.label || ""; | |||
| const user = current_machine.user || this.state.current_user; | |||
| const label = current_machine?.label || ""; | |||
There was a problem hiding this comment.
This added line is not executed by any test.
Comment on lines
+183
to
+184
| arg.then(function(...args) { console.log(...args) }, | ||
| function(...args) { console.error(...args) }); |
There was a problem hiding this comment.
These 2 added lines are not executed by any test.
| if (typeof arg.stream == "function") | ||
| arg.stream(function() { console.log.apply(console, arguments) }); | ||
| arg.stream(function(...args) { console.log(...args) }); |
There was a problem hiding this comment.
This added line is not executed by any test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.