cockpit-ci: Update container to 2025-01-04 #21487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
changed the title
allisonkarlitskaya
pushed a commit
that referenced
this pull request
Jan 6, 2025
allisonkarlitskaya
force-pushed
the
tasks-container-update-cockpit-ci-container-20250106-023028
branch
from
97a16c5 to
51c066d
Compare
|
martinpitt
pushed a commit
that referenced
this pull request
Jan 6, 2025
martinpitt
force-pushed
the
tasks-container-update-cockpit-ci-container-20250106-023028
branch
from
51c066d to
6f21032
Compare
|
I'm not super happy about this, but I don't see a better way. |
martinpitt
force-pushed
the
tasks-container-update-cockpit-ci-container-20250106-023028
branch
from
6f21032 to
ce7d63b
Compare
|
It seems the flatpak test now consistently fails. GitHub just switched "ubuntu-latest" to from 22.04 to 24.04. Let's figure this out separately. We have more pressing piloting/todo issues right after the holiday break, I added this to the pilot board. |
mypy 1.14 now complains about an `arg-type` issue: > src/cockpit/channels/filesystem.py:565: error: > Argument 1 to "report_error" of "FsInfoChannel" has incompatible type "int | None"; expected "int" In our case we know that `Handle.open` will always fail with a valid errno, so assert it. This requires an additional noqa marker, as otherwise ruff complains about using `assert` in an `except` handler.
GitHub just switched "ubuntu-latest" from 22.04 to 24.04. The flatpak test needs to be adjusted to that, but not as part of this PR.
martinpitt
force-pushed
the
tasks-container-update-cockpit-ci-container-20250106-023028
branch
from
ce7d63b to
e737ba7
Compare
martinpitt
added
the
.github-changes
mvollmer
pushed a commit
that referenced
this pull request
Jan 7, 2025
mvollmer
deleted the
tasks-container-update-cockpit-ci-container-20250106-023028
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.