workflows: Move release and node-modules workflows from Ubuntu 20.04 to 24.04 #21495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to 24.04 20.04 will soon be EOL. "ubuntu-latest" is 24.04 now with a newer podman.
martinpitt
added
no-test
mvollmer
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
20.04 will soon be EOL. "ubuntu-latest" is 24.04 now with a newer podman.
These workflows are hard to test in "proper" PRs (
on: pull_request_targetand needing a tag), so I tested them on my fork. I pushed this branch to my fork's main and tagged a 999 release, which succeeded (the "source" part anyway -- of course flathub etc. fails, as it doesn't have credentials).I also created martinpitt#23 that runs reposchutz, and it fails in the expected way. I.e. the build and tar diffing worked fine, and it fails with the expected package.json diff.