cockpit: retain SELinux context if file exists #21506
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the Cockpit Files editor fsreplace1 is used to write new content to an existing file. If an administrator has set a custom selinux context to such a file, for example a config file shared into a container the SELinux context is not kept which leads to unexpected behaviour. Closes: cockpit-project#21505
jelly
force-pushed
the
fsreplace-selinux-context
branch
from
497c01f to
9c2f2db
Compare
cockpituous
reviewed
Jan 13, 2025
Comment on lines
+147
to
+149
| file.replace(content, use_tag ? tag : undefined) | ||
| .catch(exc => { | ||
| fsreplace_error.textContent = exc.toString(); |
There was a problem hiding this comment.
These 3 added lines are not executed by any test.
|
a-webui looks really messy. Two tests are known broken, but not that badly. So let's retry to be sure. The failures are all on ND@1, so this reeks of "VM corruption". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the Cockpit Files editor fsreplace1 is used to write new content to an existing file. If an administrator has set a custom selinux context to such a file, for example a config file shared into a container the SELinux context is not kept which leads to unexpected behaviour.
Closes: #21505