tasks: Add integration test for image-refresh via issue-scan #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename it to "mock-github" and rename `--print-event` to `--print-pr-event`. That way we can use it for other events, like an issue with an image-refresh task.
martinpitt
force-pushed
the
image-refresh-test
branch
from
f0e1ecb to
0f99819
Compare
6 tasks
This covers the real thing in between getting the "issue" webhook data and uploading the image to the S3 server, and hence `issue-scan`, `image-refresh`, `image-create`, S3 image credentials, etc. Extend mock-github for the operations that `image-refresh` does, like converting an issue to a pull, posting test statuses, etc. These aren't asserted: it's possible in principle with keeping state in the mock, but these aren't the parts that are sensitive to us changing our bots infrastructure. Also, these are better done in bots' unittests than this integration test.
martinpitt
force-pushed
the
image-refresh-test
branch
from
0f99819 to
a1a1e5a
Compare
martinpitt
commented
Mar 6, 2024
tasks/run-local.sh
Outdated
| echo "--------------- mock image-refresh test log end -------------" | ||
| assert_in 'Running on:.*cockpituous' "$LOG" | ||
| assert_in './image-create.*foonux' "$LOG" | ||
| assert_in 'Uploading to' "$LOG" # TODO: make this more precise |
There was a problem hiding this comment.
Ah, forgot about that -- fixed.
allisonkarlitskaya
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers the real thing in between getting the "issue" webhook data
and uploading the image to the S3 server, and hence
issue-scan,image-refresh,image-create, S3 image credentials, etc.Extend mock-github for the operations that
image-refreshdoes, likeconverting an issue to a pull, posting test statuses, etc. These aren't
asserted: it's possible in principle with keeping state in the mock,
but these aren't the parts that are sensitive to us changing our bots
infrastructure. Also, these are better done in bots' unittests than this
integration test.
TODO: