Properly fix podman.socket permissions in tasks containers #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gets rid of duplicating the magic number "1111" in a lot of places. It's also a prerequisite for the next commit, as systemd doesn't like refering to random GIDs in units.
jelly
previously approved these changes
Mar 13, 2024
The `ExecStartPre=` was a quick hack, but it goes against the declared system state and e.g. doesn't survive restarts of `podman.socket`. Declare that properly with a unit drop-in.
When the tasks/job containers access the bind-mounted podman.sock, they currently run into a lot of SELinux denials. This happened to work as we have run SELinux in permissive mode on our bots in the last two weeks (see commit c118069). Create a proper SELinux policy plugin instead, so that we can put it back into enforce mode.
martinpitt
force-pushed
the
socket-permissions
branch
from
f95744d to
83d7f8c
Compare
|
@jelly I only deployed/tested it on rhos-01-1 before, I wanted to wait for the review. I fully deployed it, and unfortunately I was missing a trivial bit -- the I rolled it out everywhere with that fix, and re-enabled SELinux on all boxes. |
jelly
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for details.
I rolled this out onto rhos-01-1, switched it back to
setenforce 1, and confirmed thatsudo podman exec -it cockpit-tasks-1 podman-remote --url unix:///podman.sock psworks and also doesn't leave any "AVC denied" injournalctl -f.