Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Box2D JSB normalImpulses/tangentImpulses properties were not bound. #18546

Open
wants to merge 1 commit into
base: v3.8.7
Choose a base branch
from

Conversation

dumganhar
Copy link
Contributor

Re: https://forum.cocos.org/t/topic/165212/600?u=dumganhar

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@dumganhar dumganhar requested a review from tangkaikk April 1, 2025 09:13
Copy link

github-actions bot commented Apr 1, 2025

Code Size Check Report

Wechat (WASM) Before After Diff
2D Empty (legacy pipeline) 1002433 bytes 1002433 bytes ✅ 0 bytes
2D All (legacy pipeline) 2664474 bytes 2664474 bytes ✅ 0 bytes
2D All (new pipeline) 2752682 bytes 2752682 bytes ✅ 0 bytes
(2D + 3D) All 10005962 bytes 10005962 bytes ✅ 0 bytes
Web (WASM + ASMJS) Before After Diff
(2D + 3D) All 16919743 bytes 16919743 bytes ✅ 0 bytes

Interface Check Report

This pull request does not change any public interfaces !

@dumganhar dumganhar requested a review from bofeng-song April 1, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant