Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome Extension Locale Key Naming Issue Report
Issue Summary
The YouTube extension failed to pack due to invalid locale key names in the Chinese (Simplified) locale file (
_locales/zh_CN/messages.json
). Chrome extensions have strict naming conventions for locale keys that only allow ASCII letters (a-z, A-Z), numbers (0-9), and underscores (_).Problem Details
Root Cause
Several locale keys in the Chinese locale file contained invalid characters, including:
Affected Keys
The following invalid keys were identified and corrected:
"Disable video playback on hover"
"disableThumbnailPlayback"
"Dim Youtube's Pages, except what I mouse-over!"
"cursorLighting"
"Hide AI Summaries"
"hideAiSummaries"
"Hide Banner Ads (YouTube might deny)"
"hideBannerAds"
"Hide Pause Overlay"
"hidePauseOverlay"
"Hide YouTube Logo"
"hideYouTubeLogo"
"Hide '⫶' (more actions) on thumbnails"
"hideMoreActionsOnThumbnails"
"Hide watched videos"
"hideWatchedVideos"
"Remove member only videos"
"RemoveMemberOnlyVideos"
"Thumbnail Size"
"ThumbnailSize"
"Youtube-Search"
"YoutubeSearch"
Technical Requirements
Chrome Extension Locale Key Naming Rules
According to Chrome Extension documentation, locale message keys must:
Error Messages Encountered
Resolution Process
Step 1: Identification
Step 2: Cross-Reference
_locales/en/messages.json
) to find correct key namesStep 3: Correction
Step 4: Validation
Prevention Measures
For Future Development
Recommended Naming Patterns
hideYouTubeLogo
,disableThumbnailPlayback
youtube_search
,thumbnail_size
Files Modified
_locales/zh_CN/messages.json
- All invalid keys correctedTesting
Impact
Yes, I used AI for this MD, but when I was working with this repo and trying to unpack it locally, I came across a translation problem that conflicted with the JSON formatting for Chrome, so I tried to fix it. I hope it helps