Add search item tooltip #2523
Add search item tooltip #2523
Conversation
|
@chrjorgensen any chance you can fix that conflict? |
chrjorgensen
temporarily deployed
to
testing_environment
GitHub Actions
Inactive
|
@worksofliam Done - had to eat first... 😉 |
| * @param path | ||
| * @return IFSFile | ||
| */ | ||
| async getFileInfo(path: string): Promise<IFSFile> { |
There was a problem hiding this comment.
I think we are going to need some new test cases for this method.
There was a problem hiding this comment.
I will add some test cases...
| @@ -110,9 +110,13 @@ export namespace Search { | |||
| }); | |||
|
|
|||
| if (grepRes.code == 0) { | |||
| const hits = parseGrepOutput(grepRes.stdout); | |||
| for (var i = 0; i < hits.length; i++) { | |||
| hits[i].file = await connection.content.getFileInfo(hits[i].path) | |||
There was a problem hiding this comment.
Has this been testing with a large hits array length? I wonder if getFileInfo might be nicely suited to accept an array as parameter and then call stat with multiple paths? Is that possible?
There was a problem hiding this comment.
It has not been tested, but both stat and ls supports multiple filenames, so I will change the function to accept an array of filenames and return an array of files info.
|
@chrjorgensen Please update this branch with the changes from master, but make sure your fix to |
Changes
This PR will add tooltips to the items in the search result view:
Members:
Streamfiles:
Streamfiles - find:
Included in the PR is a fix for invalid dates from the
getMemberInfoandgetMultipleMemberInfofunctions...How to test this PR
Examples:
Checklist