refactor: Fix phpstan isset.offset (#9383)

codeigniter4 · Jan 8, 2025 · 9de9856 · 9de9856
1 parent 72b7f8a
commit 9de9856
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 10 deletions.
diff --git a/system/Database/BaseBuilder.php b/system/Database/BaseBuilder.php
@@ -3175,6 +3175,7 @@ protected function compileWhereHaving(string $qbKey): string
                     ) {
                         continue;
                     }
+
                     // $matches = [
                     //  0 => '(test <= foo)',   /* the whole thing */
                     //  1 => '(',               /* optional */
@@ -3184,7 +3185,7 @@ protected function compileWhereHaving(string $qbKey): string
                     //  5 => ')'                /* optional */
                     // ];
 
-                    if (isset($matches[4]) && $matches[4] !== '') {
+                    if ($matches[4] !== '') {
                         $protectIdentifiers = false;
                         if (str_contains($matches[4], '.')) {
                             $protectIdentifiers = true;

diff --git a/utils/phpstan-baseline/isset.offset.neon b/utils/phpstan-baseline/isset.offset.neon
diff --git a/utils/phpstan-baseline/loader.neon b/utils/phpstan-baseline/loader.neon
@@ -16,7 +16,6 @@ includes:
     - empty.property.neon
     - function.alreadyNarrowedType.neon
     - generator.valueType.neon
-    - isset.offset.neon
     - isset.property.neon
     - method.alreadyNarrowedType.neon
     - method.childParameterType.neon