Fix impossible conditional in test

codeigniter4 · Jan 17, 2025 · cc88723 · cc88723
1 parent dfcfb1b
commit cc88723
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/tests/system/Cache/CacheFactoryTest.php b/tests/system/Cache/CacheFactoryTest.php
@@ -96,8 +96,8 @@ public function testHandlesBadHandler(): void
 
         $this->config->handler = 'dummy';
 
-        if (str_starts_with('win', strtolower(php_uname()))) {
-            $this->assertTrue(true); // can't test properly if we are on Windows
+        if (is_windows()) {
+            $this->markTestSkipped('Cannot test this properly on Windows.');
         } else {
             $this->assertInstanceOf(DummyHandler::class, $this->cacheFactory->getHandler($this->config, 'wincache', 'wincache'));
         }

diff --git a/utils/phpstan-baseline/method.alreadyNarrowedType.neon b/utils/phpstan-baseline/method.alreadyNarrowedType.neon
@@ -1,4 +1,4 @@
-# total 17 errors
+# total 16 errors
 
 parameters:
     ignoreErrors:
@@ -12,11 +12,6 @@ parameters:
             count: 2
             path: ../../tests/system/CLI/CLITest.php
 
-        -
-            message: '#^Call to method PHPUnit\\Framework\\Assert\:\:assertTrue\(\) with true will always evaluate to true\.$#'
-            count: 1
-            path: ../../tests/system/Cache/CacheFactoryTest.php
-
         -
             message: '#^Call to method PHPUnit\\Framework\\Assert\:\:assertTrue\(\) with true will always evaluate to true\.$#'
             count: 1