TLK-2622 Unit tests improvements #907
Merged
+66
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EugeneLightsOn
requested review from
malexw,
tianjing-li,
ezawadski and
a team
as code owners
EugeneLightsOn
temporarily deployed
to
development
GitHub Actions
Inactive
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #907 +/- ##
==========================================
+ Coverage 76.72% 76.75% +0.02%
==========================================
Files 272 272
Lines 10620 10638 +18
==========================================
+ Hits 8148 8165 +17
- Misses 2472 2473 +1 ☔ View full report in Codecov by Sentry. |
…api-app-once-when-building-test-fixtures
EugeneLightsOn
temporarily deployed
to
development
GitHub Actions
Inactive
ezawadski
approved these changes
Jan 15, 2025
…api-app-once-when-building-test-fixtures # Conflicts: # src/backend/main.py
EugeneLightsOn
deleted the
eugene1/tlk-2622-instantiate-fastapi-app-once-when-building-test-fixtures
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests improvements
AI Description
This PR introduces several changes to the backend unit tests and configuration files, primarily focusing on database setup and test fixtures.
DATABASE_URLin src/backend/pytest.ini has been updated to remove the database name, and a newignore::DeprecationWarninghas been added.sqlalchemy.urlvalue is now set only if it is not already set.engineandsession_chatfixtures in src/backend/tests/unit/conftest.py have been modified to use theworker_idto create a unique test database for each worker. Thesession_clientandsession_client_chatfixtures now accept thefastapi_appfixture as an argument, and thefastapi_appfixture has been added to create a session-scoped FastAPI app object.userfixture in src/backend/tests/integration/routers/test_chat.py has been changed from function to session.</co: 5>make run-unit-tests-debugtomake run-unit-tests.create_appfunction in src/backend/main.py and src/backend/pycharm_debug_main.py now includes a return type hint ofFastAPI.