v1.8.0

[davidMkCb]

v1.8.0

[cb-heimdall]

✅ Heimdall Review Status

Requirement	Status	More Info
Reviews	✅ 1/1	Denominator calculation Show calculation 1 if user is bot 0 1 if user is external 0 From .codeflow.yml 1 Additional review requirements Show calculation Max 0 0 From CODEOWNERS 0 Global minimum 0 Max 1 1 1 if commit is unverified 0 Sum 1

[danhaive]

I am having an import issue with types when trying to use 1.8.0. Had to revert to 1.7.0.

[davidMkCb]

I am having an import issue with types when trying to use 1.8.0. Had to revert to 1.7.0.

hey @danhaive, thank you for reporting! Could you give a bit more details into the issues you're having?

[supermarin]

Python 3.12.7 (main, Oct  1 2024, 02:05:46) [GCC 13.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from coinbase import websocket
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/marin/code/yolo/.venv/lib/python3.12/site-packages/coinbase/websocket/__init__.py", line 6, in <module>
    from .types.websocket_response import WebsocketResponse
ModuleNotFoundError: No module named 'coinbase.websocket.types'
>>> from coinbase import rest
>>> 

[supermarin]

Also json.dumps(response) doesn't work as per documentation:

accounts = client.get_accounts()
print(dumps(accounts, indent=2))

# TypeError: Object of type ListAccountsResponse is not JSON serializable   

EDIT: downgraded to 1.7.0, this one exists there as well. Websocket module works OK

[davidMkCb]

hey @supermarin, thanks for reporting the issues! We're working on the fixes right now.

[davidMkCb]

Hey @supermarin @danhaive, released v1.8.1 addressing these issues!

[supermarin]

@davidMkCb json serialization is still broken in 1.8.1

[urischwartz-cb]

@supermarin how are you trying to print? with the latest changes you need to us the built in to_dict() function to properly serialize the json responses. For example:

from json import dumps

accounts = client.get_accounts()
print(dumps(accounts.to_dict(), indent=2))