Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs for keysurl #116

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Update docs for keysurl #116

merged 2 commits into from
Dec 20, 2024

Conversation

spencerstock
Copy link
Contributor

In cases where you need to do an account change to add the permission manager - the user's wallet must be on the right keysUrl:

Mainnet requests: Must be on keys.coinbase.com
Testnet requests: must be on keys-dev.coinbase.com

Newly created accounts don't share this restriction.

@vercel Vercel
Copy link

vercel bot commented Dec 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
smart-wallet-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 0:34am

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Dec 20, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

amiecorso
amiecorso reviewed Dec 20, 2024
View reviewed changes
docs/pages/guides/spend-permissions/quick-start.mdx Outdated
- For mainnets: Leave `keysUrl` undefined (defaults to keys.coinbase.com)

We also want to point our chain id to Base Sepolia testnet by setting replacing all instances of `base`
with `baseSepolia` in this file (including the import).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this specify that we only want to swap out to baseSepolia in the case that we're wanting to use a testnet and have also specified keys-dev instead of keys? This makes me feel like I'm not sure which combination of URL and chain I should be using. Maybe the bit about sepolia could go directly with.under the "For testnets" line, and the "For mainnets" line could include something like: "the project template will default to base"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

amiecorso
amiecorso previously approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@amiecorso amiecorso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one idea

@cb-heimdall cb-heimdall dismissed amiecorso’s stale review December 20, 2024 00:34

Approved review 2516465136 from amiecorso is now dismissed due to new commit. Re-request for approval.

amiecorso
amiecorso approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@amiecorso amiecorso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@spencerstock spencerstock merged commit 4efce08 into main Dec 20, 2024
6 checks passed
@Forgetting-Always
Copy link

If you're looking to fuck ur money random keeeeeeo it

1 similar comment
@Forgetting-Always
Copy link

If you're looking to fuck ur money random keeeeeeo it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amiecorso amiecorso amiecorso approved these changes

@ilikesymmetry ilikesymmetry Awaiting requested review from ilikesymmetry

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spencerstock @cb-heimdall @Forgetting-Always @amiecorso