Merge pull request #15 from coinbase/wilson/refactor-multiownable

cleanup comments
coinbase · Mar 5, 2024 · 4b1ec9c · 4b1ec9c
2 parents ce796de + 3b53115
commit 4b1ec9c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/.gas-snapshot b/.gas-snapshot
@@ -29,7 +29,7 @@ TestCanSkipChainIdValidation:test_approvedSelectorsReturnTrue() (gas: 15889)
 TestCanSkipChainIdValidation:test_otherSelectorsReturnFalse() (gas: 12491)
 TestExecuteWithoutChainIdValidation:testExecute() (gas: 424683)
 TestExecuteWithoutChainIdValidation:testExecuteBatch() (gas: 729020)
-TestExecuteWithoutChainIdValidation:testExecuteBatch(uint256) (runs: 256, μ: 3421418, ~: 3274019)
+TestExecuteWithoutChainIdValidation:testExecuteBatch(uint256) (runs: 256, μ: 3419049, ~: 3273850)
 TestExecuteWithoutChainIdValidation:test__codesize() (gas: 48980)
 TestExecuteWithoutChainIdValidation:test__codesize() (gas: 49215)
 TestExecuteWithoutChainIdValidation:test_canChangeOwnerWithoutChainId() (gas: 287952)

diff --git a/src/MultiOwnable.sol b/src/MultiOwnable.sol
@@ -42,13 +42,11 @@ contract MultiOwnable {
     }
 
     /// @dev convenience function to add address owner
-    /// can be used if nextOwnerIndex < 255
     function addOwnerAddress(address owner) public virtual onlyOwner {
         _addOwner(abi.encode(owner));
     }
 
     /// @dev convenience function to add passkey owner
-    /// can be used if nextOwnerIndex < 255
     function addOwnerPublicKey(bytes32 x, bytes32 y) public virtual onlyOwner {
         _addOwner(abi.encode(x, y));
     }
@@ -93,8 +91,6 @@ contract MultiOwnable {
         }
     }
 
-    /// @dev convenience function that can be used to add the first
-    /// 255 owners.
     function _addOwner(bytes memory owner) internal virtual {
         _addOwnerAtIndex(owner, _getMultiOwnableStorage().nextOwnerIndex++);
     }