Skip to content

Commit

Permalink
Merge pull request #56 from coinbase/wilson/fix-gitignore
Browse files Browse the repository at this point in the history
do not gitignore lib
  • Loading branch information
wilsoncusack authored Apr 19, 2024
2 parents ceb82f2 + f957bb1 commit 89eb5a6
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 18 deletions.
33 changes: 17 additions & 16 deletions .gas-snapshot
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,17 @@ AddOwnerPublicKeyTest:testSetsOwnerAtIndex() (gas: 128616)
CoinbaseSmartWallet1271InputGeneratorTest:testGetReplaySafeHashForDeployedAccount() (gas: 308446)
CoinbaseSmartWallet1271InputGeneratorTest:testGetReplaySafeHashForUndeployedAccount() (gas: 291475)
CoinbaseSmartWalletFactoryTest:testDeployDeterministicPassValues() (gas: 267250)
CoinbaseSmartWalletFactoryTest:test_CreateAccount_ReturnsPredeterminedAddress_WhenAccountAlreadyExists() (gas: 287003)
CoinbaseSmartWalletFactoryTest:test_CreateAccount_ReturnsPredeterminedAddress_WhenAccountAlreadyExists() (gas: 286914)
CoinbaseSmartWalletFactoryTest:test_RevertsIfLength32ButLargerThanAddress() (gas: 298636)
CoinbaseSmartWalletFactoryTest:test_constructor_setsImplementation(address) (runs: 256, μ: 314355, ~: 314355)
CoinbaseSmartWalletFactoryTest:test_createAccountDeploysToPredeterminedAddress() (gas: 268601)
CoinbaseSmartWalletFactoryTest:test_createAccountSetsOwnersCorrectly() (gas: 277291)
CoinbaseSmartWalletFactoryTest:test_exitIfAccountIsAlreadyInitialized() (gas: 267718)
CoinbaseSmartWalletFactoryTest:test_implementation_returnsExpectedAddress() (gas: 7654)
CoinbaseSmartWalletFactoryTest:test_initCodeHash() (gas: 7890)
CoinbaseSmartWalletFactoryTest:test_revertsIfNoOwners() (gas: 29214)
CoinbaseSmartWalletFactoryTest:test_implementation_returnsExpectedAddress() (gas: 7676)
CoinbaseSmartWalletFactoryTest:test_initCodeHash() (gas: 7912)
CoinbaseSmartWalletFactoryTest:test_revertsIfNoOwners() (gas: 29232)
ERC1271Test:test_returnsExpectedDomainHashWhenProxy() (gas: 29198)
ERC1271Test:test_static() (gas: 3243921)
ERC1271Test:test_static() (gas: 3249331)
MultiOwnableInitializeTest:testRevertsIfLength32ButLargerThanAddress() (gas: 81111)
MultiOwnableInitializeTest:testRevertsIfLength32NotAddress() (gas: 81092)
MultiOwnableInitializeTest:testRevertsIfLengthNot32Or64() (gas: 103395)
Expand All @@ -40,26 +41,26 @@ RemoveOwnerAtIndexTest:test_revert_whenCalledByNonOwner(address) (runs: 256, μ:
RemoveOwnerAtIndexTest:test_revert_whenNoOwnerAtIndex() (gas: 33372)
RemoveOwnerAtIndexTest:test_revert_whenWrongOwnerAtIndex() (gas: 36694)
RemoveOwnerAtIndexTest:test_reverts_ifIsLastOwner() (gas: 7471805)
TestCanSkipChainIdValidation:test_approvedSelectorsReturnTrue() (gas: 15845)
TestCanSkipChainIdValidation:test_otherSelectorsReturnFalse() (gas: 12469)
TestCanSkipChainIdValidation:test_approvedSelectorsReturnTrue() (gas: 17781)
TestCanSkipChainIdValidation:test_otherSelectorsReturnFalse() (gas: 12579)
TestExecuteWithoutChainIdValidation:testExecute() (gas: 424837)
TestExecuteWithoutChainIdValidation:testExecuteBatch() (gas: 728897)
TestExecuteWithoutChainIdValidation:testExecuteBatch(uint256) (runs: 256, μ: 3612753, ~: 3472828)
TestExecuteWithoutChainIdValidation:test__codesize() (gas: 49960)
TestExecuteWithoutChainIdValidation:test__codesize() (gas: 50195)
TestExecuteWithoutChainIdValidation:testExecuteBatch(uint256) (runs: 256, μ: 3631749, ~: 3655292)
TestExecuteWithoutChainIdValidation:test__codesize() (gas: 49987)
TestExecuteWithoutChainIdValidation:test__codesize() (gas: 50222)
TestExecuteWithoutChainIdValidation:test_revertsWithReservedNonce() (gas: 82347)
TestExecuteWithoutChainIdValidation:test_reverts_whenCallerNotEntryPoint() (gas: 11053)
TestExecuteWithoutChainIdValidation:test_reverts_whenOneCallReverts() (gas: 467906)
TestExecuteWithoutChainIdValidation:test_reverts_whenOneSelectorNotApproved() (gas: 179678)
TestExecuteWithoutChainIdValidation:test_reverts_whenSelectorNotApproved() (gas: 106769)
TestExecuteWithoutChainIdValidation:test_succeeds_whenSelectorAllowed() (gas: 424367)
TestExecuteWithoutChainIdValidation:test_reverts_whenOneCallReverts() (gas: 467957)
TestExecuteWithoutChainIdValidation:test_reverts_whenOneSelectorNotApproved() (gas: 179805)
TestExecuteWithoutChainIdValidation:test_reverts_whenSelectorNotApproved() (gas: 106879)
TestExecuteWithoutChainIdValidation:test_succeeds_whenSelectorAllowed() (gas: 424401)
TestImplementation:testImplementation() (gas: 12623)
TestInitialize:testInitialize() (gas: 21034)
TestInitialize:test_cannotInitImplementation() (gas: 2899105)
TestInitialize:test_cannotInitImplementation() (gas: 2904513)
TestIsValidSignature:testReturnsInvalidIfPasskeySigButWrongOwnerLength() (gas: 40187)
TestIsValidSignature:testRevertsIfEthereumSignatureButWrongOwnerLength() (gas: 24040)
TestIsValidSignature:testRevertsIfOwnerIsInvalidEthereumAddress() (gas: 22021)
TestIsValidSignature:testSmartWalletSigner() (gas: 3174740)
TestIsValidSignature:testSmartWalletSigner() (gas: 3180147)
TestIsValidSignature:testValidateSignatureWithEOASigner() (gas: 24922)
TestIsValidSignature:testValidateSignatureWithEOASignerFailsWithWrongSigner() (gas: 23877)
TestIsValidSignature:testValidateSignatureWithPasskeySigner() (gas: 423238)
Expand Down
2 changes: 0 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,4 @@ docs/
.env
.VSCodeCounter/

lib/

.certora_internal/
5 changes: 5 additions & 0 deletions test/CoinbaseSmartWalletFactory.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ contract CoinbaseSmartWalletFactoryTest is Test {
owners.push(abi.encode(address(2)));
}

function test_constructor_setsImplementation(address implementation) public {
factory = new CoinbaseSmartWalletFactory(implementation);
assertEq(factory.implementation(), implementation);
}

function test_createAccountSetsOwnersCorrectly() public {
address expectedAddress = factory.getAddress(owners, 0);
vm.expectCall(expectedAddress, abi.encodeCall(CoinbaseSmartWallet.initialize, (owners)));
Expand Down

0 comments on commit 89eb5a6

Please sign in to comment.