Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CI workflow to build the extension and upload it to PyPI #28

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

esteve
Copy link
Collaborator

@esteve esteve commented Oct 17, 2024

No description provided.

Signed-off-by: Esteve Fernandez <esteve@apache.org>
@esteve esteve marked this pull request as ready for review October 17, 2024 14:14
@esteve
Copy link
Collaborator Author

esteve commented Oct 17, 2024

I wasn't sure whether to restrict this to only releases or just enable it for any tag. @luca-della-vedova @mxgrey @maspe36 @jhdcs, thoughts?

Copy link
Member

@luca-della-vedova luca-della-vedova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷 not a big difference imho, releases are a bit more intentional so there is less risk of mistakenly uploading a version to Pypi, so imho this is good to go, we can test this with a bump and re-release with the updated dependency on cargo-ament-build

@esteve esteve merged commit 7bb8db4 into main Oct 30, 2024
16 checks passed
@esteve esteve deleted the add-ci-release branch October 30, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants