Reuse colcon_ros package identification #32
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the manual package identification step and just reuses the
colcon_ros
package identification. The package will now only implementbuild
andtest
tasks and letcolcon_ros
handle identification.I ported the error warning for missing
cargo-ament-build
that is now a build time error rather than an identification time warning (perhaps a better failure mode?), I haven't ported the missingCargo.toml
error though (cargo-ament-build
will fail anyway in that scenario, we should probably just improve the error on that side)