Instrument with ActiveSupport::Notifications #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albus522
reviewed
Dec 4, 2023
Co-authored-by: David Genord II <david@collectiveidea.com>
Rails 7.0 supported 2.7. Test against that too.
albus522
reviewed
Dec 5, 2023
.github/workflows/ci.yml
Outdated
| @@ -14,6 +14,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| ruby: | |||
| - '2.7.8' | |||
There was a problem hiding this comment.
yeah, I guess I should care 🤣
danielmorrison
force-pushed
the
active-support-notifications
branch
from
90b91ae to
e2208da
Compare
danielmorrison
commented
Dec 5, 2023
| - '3.1.3' | ||
| - '3.2.0' | ||
| - 2.7 | ||
| - '3.0' # keep as string or it turns into "3" which pulls the newest 3.x, not 3.0.x |
albus522
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking some inspiration from ruby-grape/grape#1086
This may change a bit, but want to give us something to start with.
I'm also adding more tests along the way.