Skip to content

Commit

Permalink
chore: remove deprecated methods
Browse files Browse the repository at this point in the history
  • Loading branch information
taka-oyama committed Jan 26, 2024
1 parent 017e198 commit 8dd0a83
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 91 deletions.
22 changes: 0 additions & 22 deletions src/Concerns/ManagesDataDefinitions.php
Original file line number Diff line number Diff line change
Expand Up @@ -30,28 +30,6 @@ trait ManagesDataDefinitions
*/
abstract public function getSpannerDatabase(): Database;

/**
* @deprecated use runDdlBatch() instead
* @param string $ddl
* @return LongRunningOperation
*/
public function runDdl(string $ddl): LongRunningOperation
{
trigger_deprecation('colopl/laravel-spanner', '5.2', 'runDdl() is deprecated. Use runDdlBatch() instead.');
return $this->getSpannerDatabase()->updateDdl($ddl);
}

/**
* @deprecated use runDdlBatch() instead
* @param string[] $ddls
* @return LongRunningOperation
*/
public function runDdls(array $ddls): LongRunningOperation
{
trigger_deprecation('colopl/laravel-spanner', '5.2', 'runDdls() is deprecated. Use runDdlBatch() instead.');
return $this->getSpannerDatabase()->updateDdlBatch($ddls);
}

/**
* @param list<string> $statements
* @return mixed
Expand Down
64 changes: 0 additions & 64 deletions src/Concerns/ManagesStaleReads.php

This file was deleted.

1 change: 0 additions & 1 deletion src/Connection.php
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ class Connection extends BaseConnection
Concerns\ManagesPartitionedDml,
Concerns\ManagesSessionPool,
Concerns\ManagesTransactions,
Concerns\ManagesStaleReads,
Concerns\MarksAsNotSupported;

/**
Expand Down
4 changes: 2 additions & 2 deletions src/Schema/Blueprint.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
use Illuminate\Database\Schema\Blueprint as BaseBlueprint;
use Illuminate\Database\Schema\ColumnDefinition;
use Illuminate\Support\Fluent;
use LogicException;

/**
* @method IndexDefinition index(string|string[] $columns, string|null $name = null)
Expand Down Expand Up @@ -219,8 +220,7 @@ public function timestampArray($column)
*/
public function interleave(string $parentTableName)
{
trigger_deprecation('colopl/laravel-spanner', '5.2', 'Blueprint::interleave() is deprecated. Use interleaveInParent() instead. This method will be removed in v7.');
return $this->interleaveInParent($parentTableName);
throw new LogicException('This method is not longer valid. Use interleaveInParent() instead.');
}

/**
Expand Down
4 changes: 2 additions & 2 deletions src/Schema/IndexDefinition.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
namespace Colopl\Spanner\Schema;

use Illuminate\Support\Fluent;
use LogicException;

/**
* @method $this interleaveIn(string $table)
Expand All @@ -19,7 +20,6 @@ class IndexDefinition extends Fluent
*/
public function interleave(string $table)
{
trigger_deprecation('colopl/laravel-spanner', '5.2', 'Blueprint::interleave() is deprecated. Use interleaveIn() instead. This method will be removed in v7.');
return $this->interleaveIn($table);
throw new LogicException('This method is not longer valid. Use interleaveIn() instead.');
}
}

0 comments on commit 8dd0a83

Please sign in to comment.