Allow pretending for DDL statements #162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Takayasu Oyama <taka.oyama@gmail.com>
Co-authored-by: Takayasu Oyama <taka.oyama@gmail.com>
Co-authored-by: Takayasu Oyama <taka.oyama@gmail.com>
taka-oyama
reviewed
Jan 5, 2024
Comment on lines
+169
to
+171
|
|
||
| if(count($queries)) | ||
| $connection->runDdlBatch($queries); |
There was a problem hiding this comment.
These fixes don't belong in this PR.
There was a problem hiding this comment.
ye fair i merged from the other drop-all branch into this
taka-oyama
reviewed
Jan 5, 2024
| @@ -295,6 +295,10 @@ public function statement($query, $bindings = []): bool | |||
| } | |||
|
|
|||
| // is DDL Query | |||
| // allow pretending for DDL queries | |||
| if($this->pretending()) | |||
| return $this->affectingStatement($query, $bindings) !== null; | |||
There was a problem hiding this comment.
I think runDdlBatch should be fixed to handle the pretending instead of forwarding it to affectingStatement.
There was a problem hiding this comment.
but isnt affectingStatement()s implementation of pretend is basically complete and simple and i would just end up duplicating affectingStatement() line for line, except for this range of lines
https://github.com/colopl/laravel-spanner/blob/master/src/Connection.php#L313-L323
There was a problem hiding this comment.
or is nothing in the affectingStatement method relevant?
|
Fixed in #170. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the Connection is pretending, the DDL statements should not run
Since affectingStatement already handles pretending, its fine to just pass through to that method which will return 0 as normal, allowing the generated SQL to be captured