feat: allow default transaction attempts to be changed #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taka-oyama
requested review from
dkkoma,
kt81,
zeriyoshi,
halnique,
Uyan712 and
t-matsuno-777
dkkoma
approved these changes
Feb 16, 2024
taka-oyama
force-pushed
the
feat/add-transaction-attempt-setter
branch
from
3fdf7f6 to
c9faa11
Compare
taka-oyama
force-pushed
the
feat/add-transaction-attempt-setter
branch
from
c9faa11 to
dc0aa0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning:
Connection::transaction()'s$attemptsargument's default value was changed from 10 to -1 (which is a magic number for default value which is 11).Default is set to 11 because Spanner library sets default retries to 10 and we add 1 to that since laravel defines amount of attempts not amount of retries.