Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use default PHP 8.4 #11

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Use default PHP 8.4 #11

merged 1 commit into from
Nov 22, 2024

Conversation

zeriyoshi
Copy link
Contributor

@zeriyoshi zeriyoshi self-assigned this Nov 22, 2024
@yamadashy
Copy link

あまり詳しくないですが、このパッチって8.4では不要になった感じですかね

pskel/pskel.sh

Line 128 in 81f05ed

if [ "$("${CMD}" -r "echo PHP_VERSION_ID;")" -lt "80400" ]; then

@zeriyoshi
Copy link
Contributor Author

@yamadashy
はい、修正済みです！
php/php-src@d6afe05

@yamadashy
Copy link

おお、流石！

@zeriyoshi zeriyoshi merged commit 32ea3cf into colopl:main Nov 22, 2024
3 checks passed
@zeriyoshi zeriyoshi deleted the php84 branch November 22, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yamadashy yamadashy yamadashy approved these changes

Assignees

@zeriyoshi zeriyoshi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zeriyoshi @yamadashy