Don't accept CI secrets on CLI in SonatypeCentralPublishModule #5543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These secrets might leak with Mill's prompt, that tries to print back the command arguments. These might be truncated in particular, which can make parts of these secrets slip through output secret detection.
Conflicts: libs/javalib/src/mill/javalib/SonatypeCentralPublishModule.scala
|
Perhaps we should make Mill support taking in |
|
@arturaz Maybe at some point, yes. We need better secret management overall, some secrets might leak in serialized task results under |
Conflicts: libs/javalib/src/mill/javalib/SonatypeCentralPublishModule.scala
lefou
reviewed
Aug 22, 2025
Comment on lines
+298
to
+305
| val isCI = Task.env.get("CI").nonEmpty | ||
| if (!force && isCI && (usernameParameterValue.nonEmpty || passwordParameterValue.nonEmpty)) | ||
| sys.error( | ||
| "--username and --password options forbidden on CI. " + | ||
| "Their use might leak secrets. " + | ||
| s"Pass those values via environment variables instead ($USERNAME_ENV_VARIABLE_NAME and $PASSWORD_ENV_VARIABLE_NAME), or pass --force alongside them. " + | ||
| "You might want to check the output of this job for a leak of those secrets or parts of them." | ||
| ) |
There was a problem hiding this comment.
Since we consider this unsafe, we might as well print the same message as warning in all other cases.
Also, instead of sys.error use Task.fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
SonatypeCentralPublishModulerefuse credentials passed via--usernameand--passwordif it detects it's running on a CI. Using these arguments poses security issues: the Mill's prompt tries to print them back, like in(prompt obtained by running a command like
./mill -i mill.scalalib.SonatypeCentralPublishModule/ --username … --password …, containing parts of a now revoked token)These secrets might be truncated in particular, which can make parts of these secrets slip through output secret detection.