-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reapply "Online lateral lag learning" #34975
base: master
Are you sure you want to change the base?
Conversation
This reverts commit b4cc9e6.
7ebf1fd
to
82317b7
Compare
…-34531-online-lag
a85881a
to
0d2922f
Compare
The pop-up message on the on-road screen is supposed to be floating, but isn't that supposed to be floating? The pop-up message on the on-road screen is supposed to be floating, but isn't that supposed to be floating? How can I get it floating on the on-road screen? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Files not reviewed (1)
- selfdrive/test/process_replay/ref_commit: Language not supported
Comments suppressed due to low confidence (1)
selfdrive/locationd/lagd.py:250
- [nitpick] The calculation of new_values_start_idx using negative indices from a reversed list is non-obvious; consider adding an inline comment or refactoring the logic for better clarity.
new_values_start_idx = next(-i for i, t in enumerate(reversed(times)) if t <= self.last_estimate_t)
4c85fa8
to
e216a74
Compare
12da82a
to
9ab94c8
Compare
…-34531-online-lag
…-34531-online-lag
…-34531-online-lag
Reverts #34974
TODO:
update_estimate
RIVIAN
segment from process replay has enough valid data to cover itlet it sink in and merge on monday