Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply "Online lateral lag learning" #34975

Open
wants to merge 44 commits into
base: master
Choose a base branch
from

Conversation

fredyshox
Copy link
Contributor

@fredyshox fredyshox commented Apr 1, 2025

Reverts #34974

TODO:

  • make tests (unit or process replay) cover the cross correlation codepath in update_estimate
    • RIVIAN segment from process replay has enough valid data to cover it
  • tweak fft size for performance
  • write unit tests
  • regen logs for selfdrived

let it sink in and merge on monday

Sorry, something went wrong.

This reverts commit b4cc9e6.
@fredyshox fredyshox force-pushed the revert-34974-revert-34531-online-lag branch from 7ebf1fd to 82317b7 Compare April 2, 2025 00:08
…-34531-online-lag
@fredyshox fredyshox force-pushed the revert-34974-revert-34531-online-lag branch from a85881a to 0d2922f Compare April 2, 2025 23:16
fredyshox added 11 commits April 2, 2025 16:22
@gomtings
Copy link

gomtings commented Apr 3, 2025

The pop-up message on the on-road screen is supposed to be floating, but isn't that supposed to be floating? The pop-up message on the on-road screen is supposed to be floating, but isn't that supposed to be floating? How can I get it floating on the on-road screen?
//liveDelay
const auto steer_delay = sm["liveDelay"].lateralDelay()
Is it possible to import it like this from the qt code on the on-road?

@fredyshox fredyshox requested a review from Copilot April 3, 2025 21:49
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • selfdrive/test/process_replay/ref_commit: Language not supported
Comments suppressed due to low confidence (1)

selfdrive/locationd/lagd.py:250

  • [nitpick] The calculation of new_values_start_idx using negative indices from a reversed list is non-obvious; consider adding an inline comment or refactoring the logic for better clarity.
new_values_start_idx = next(-i for i, t in enumerate(reversed(times)) if t <= self.last_estimate_t)

@fredyshox fredyshox force-pushed the revert-34974-revert-34531-online-lag branch from 4c85fa8 to e216a74 Compare April 4, 2025 03:41
@fredyshox fredyshox force-pushed the revert-34974-revert-34531-online-lag branch from 12da82a to 9ab94c8 Compare April 4, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants