Skip to content

Re-enable animations inside modal presentation modifiers #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025
Merged

Re-enable animations inside modal presentation modifiers #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Sources/ComponentsKit/Components/Modal/SwiftUI/Helpers/ModalPresentationModifier.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ struct ModalPresentationModifier<Modal: View>: ViewModifier {

func body(content: Content) -> some View {
content
.transaction {
$0.disablesAnimations = false
}
.onAppear {
if self.isContentVisible {
self.isPresented = true
Expand Down
3 changes: 3 additions & 0 deletions ...es/ComponentsKit/Components/Modal/SwiftUI/Helpers/ModalPresentationWithItemModifier.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ struct ModalPresentationWithItemModifier<Modal: View, Item: Identifiable>: ViewM

func body(content: Content) -> some View {
content
.transaction {
$0.disablesAnimations = false
}
.onAppear {
self.presentedItem = self.visibleItem
}
Expand Down