Fixed bug issues in bridge routing logics, as it was written for hand…

…ling only 1 accounts, when have multiple it will brdige all 0 balance accounts
compound-finance · Oct 25, 2024 · e3acbc8 · e3acbc8
1 parent fec5c4f
commit e3acbc8
Showing 1 changed file with 24 additions and 22 deletions.
diff --git a/src/builder/Actions.sol b/src/builder/Actions.sol
@@ -564,28 +564,30 @@ library Actions {
                     }
                 }
 
-                amountLeftToBridge -= amountToBridge;
-
-                (IQuarkWallet.QuarkOperation memory operation, Actions.Action memory action) = bridgeAsset(
-                    BridgeAsset({
-                        chainAccountsList: chainAccountsList,
-                        assetSymbol: bridgeInfo.assetSymbol,
-                        amount: amountToBridge,
-                        // where it comes from
-                        srcChainId: srcChainAccounts.chainId,
-                        sender: srcAccountBalances[j].account,
-                        // where it goes
-                        destinationChainId: bridgeInfo.dstChainId,
-                        recipient: bridgeInfo.recipient,
-                        blockTimestamp: bridgeInfo.blockTimestamp
-                    }),
-                    payment,
-                    bridgeInfo.useQuotecall
-                );
-
-                List.addAction(actions, action);
-                List.addQuarkOperation(quarkOperations, operation);
-                bridgeActionCount++;
+                if (amountToBridge > 0) {
+                    amountLeftToBridge -= amountToBridge;
+
+                    (IQuarkWallet.QuarkOperation memory operation, Actions.Action memory action) = bridgeAsset(
+                        BridgeAsset({
+                            chainAccountsList: chainAccountsList,
+                            assetSymbol: bridgeInfo.assetSymbol,
+                            amount: amountToBridge,
+                            // where it comes from
+                            srcChainId: srcChainAccounts.chainId,
+                            sender: srcAccountBalances[j].account,
+                            // where it goes
+                            destinationChainId: bridgeInfo.dstChainId,
+                            recipient: bridgeInfo.recipient,
+                            blockTimestamp: bridgeInfo.blockTimestamp
+                        }),
+                        payment,
+                        bridgeInfo.useQuotecall
+                    );
+
+                    List.addAction(actions, action);
+                    List.addQuarkOperation(quarkOperations, operation);
+                    bridgeActionCount++;
+                }
             }
         }