Refactor QuarkBuilder and Bridge routing fix #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cwang25
commented
Oct 23, 2024
•
cwang25
commented
- Trim off repetitive codes from quark scripts into individual files for ease of maintainability and readability.
- Adjusted some test assertion on revert that was different due to when people copying codes in quark scripts people changed a bit here and there causing some discrepancies on some check logics (such as check sufficient payment token, check sufficient bridges...etc) Now with shared base code, it will always goes through the exact same checks and codes
- Bug fix to bridge routing logics. Old bridge logics will try to bridge 0 balances if multiple accounts appears in the list. Now it won't try to bridge zero balance assets. (Found from after adding all alice/bob/fella accounts across all chain-id.
|
|
||
| // Then, transfer `amount` of `assetSymbol` to `recipient` | ||
| (IQuarkWallet.QuarkOperation memory operation, Actions.Action memory action) = Actions.transferAsset( | ||
| Actions.TransferAsset({ |
There was a problem hiding this comment.
Nit: if the function is Actions.transferAsset, maybe the struct should be Actions.TransferAssetParams or like?
a little ambiguous as-is, but of course not a big deal; not blocking.
There was a problem hiding this comment.
That sounds good to me. But I do see similar patterns in other actions too. Maybe I will create a quick follow-up PR to change all patterns to XXXParams 👍
…ling only 1 accounts, when have multiple it will brdige all 0 balance accounts
cwang25
changed the title
added 2 commits
October 25, 2024 13:39
kevincheng96
approved these changes
Oct 28, 2024
Co-authored-by: Kevin Cheng <kevincheng96@hotmail.com>
Co-authored-by: Kevin Cheng <kevincheng96@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.